Skip to content

Migrate all tests to JUnit5 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jra-se merged 19 commits into from
Jan 19, 2026
Merged

Migrate all tests to JUnit5 #232

jra-se merged 19 commits into from
Jan 19, 2026

Conversation

@jra-se
Copy link
Contributor

@jra-se jra-se commented Dec 29, 2025

  • migrate all tests to JUnit 5 API
  • remove all org.junit.vintage:junit-vintage-engine dependencies as its a compatibility layer to run JUnit 4 tests in JUnit 5
  • add org.junit.platform:junit-platform-launcher dependencies to all modules as recommended (or even required for newer Gradle versions)

@github-actions
Copy link

github-actions bot commented Dec 29, 2025 •
edited
Loading

✔️ Changes pass the MontiVerse

Project Status
details
Project Status
montiarc ✅
umlp ✅
sd ✅
montifun ✅
fd ✅
automaton ✅
sc ✅
guidsl ✅
artifacts ✅
ocl ✅
od ✅
ucd ✅
langexperiments ✅
json ✅
xml ✅
cd2gui ✅
mlc ✅
cd4analysis ✅
monticore_basic ✅
class2mc ⏩

The MontiVerse is a collection of (internal and public) language projects.

@jra-se
Copy link
Contributor Author

jra-se commented Dec 29, 2025

requires merge of MontiCore/cd4analysis#82 before merge

@luepges
Copy link
Contributor

luepges commented Jan 9, 2026

Gradle files look okay, the first 100 java files too :D

There appears to be 3 additional tests being skipped.
Could it be caused by the @Disabled now being in effect? (e.g. in MontiCoreToolTest.java)

project dev update-junit-5
build-generator 1380 tests run, 1377 passed, 3 skipped, 0 failed 1380 tests run, 1377 passed, 3 skipped, 0 failed
build-mc 6718 tests run, 6701 passed, 17 skipped, 0 failed 6716 tests run, 6696 passed, 20 skipped, 0 failed ⚠️
test-01-exp 308 tests run, 293 passed, 15 skipped, 0 failed 308 tests run, 293 passed, 15 skipped, 0 failed
test-02-exp 88 tests run, 88 passed, 0 skipped, 0 failed. 88 tests run, 88 passed, 0 skipped, 0 failed.
test-it 336 tests run, 336 passed, 0 skipped, 0 failed 336 tests run, 336 passed, 0 skipped, 0 failed
test-it-emf No test results found! No test results found!
test-grammar-it 15 tests run, 15 passed, 0 skipped, 0 failed. 15 tests run, 15 passed, 0 skipped, 0 failed.
test-montitrans 158 tests run, 156 passed, 2 skipped, 0 failed. 158 tests run, 156 passed, 2 skipped, 0 failed.

@jra-se
Copy link
Contributor Author

jra-se commented Jan 16, 2026 •
edited
Loading

There appears to be 3 additional tests being skipped. Could it be caused by the @Disabled now being in effect?

The the @Test annotation in de.monticore.templateEnginePerformance.TemplateEngineBenchmark was imported from JUnit 4, while the class itself was annoteted with the JUnit 5 @Disable. As a result, the tests were executed as JUnit 4 tests by the junit-vintage-engine which ignored the @Disable annotation.

This pull request correctly replaced the JUnit 4 import which resulted in the originally intended behaviour: the tests are skipped.

@jra-se jra-se merged commit e3f245b into dev Jan 19, 2026
33 of 34 checks passed
@jra-se jra-se deleted the update-junit-5 branch January 19, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luepges luepges luepges approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jra-se @luepges